[Scummvm-tracker] [ScummVM] #5431: AGOS: Code analysis warnings

[David Turner]

#5431: AGOS: Code analysis warnings
-----------------------+--------------------------
  Reporter:  Templier  |      Owner:  bluegr
      Type:  defect    |     Status:  closed
  Priority:  normal    |  Component:  Engine: AGOS
Resolution:  fixed     |   Keywords:  build
      Game:            |
-----------------------+--------------------------
Changes (by digitall):

 * component:   => Engine: AGOS


Old description:

> {{{#!Markdown
> Here are the warnings I get when compiling the AGI engine using Code
> Analysis in VS2010.
>
> I tried to remove all the obvious false positives. Some warnings look
> suspicious, others are pointing to correct code that still might benefit
> from better error checking.
>
> d:\sources\scummvm\scummvm\engines\agos\script\_pn.cpp\(894\): warning
> C6011: Dereferencing NULL pointer '\_stackbase'
> d:\sources\scummvm\scummvm\engines\agos\string.cpp\(858\): warning C6011:
> Dereferencing NULL pointer 'ptr' \(looks like a false positive\)
> d:\sources\scummvm\scummvm\engines\agos\verb\_pn.cpp\(188\): warning
> C6011: Dereferencing NULL pointer '\_dragStore'
>
> Note: If you want to try it yourself, you will need:
> \- the create\_project patch set, along with the WIP code analysis patch
> \(http://bitbucket.org/Littleboy/scummvm-jt/src/942f13a9f24b \)
> \- the following patch to silence some false positives \(
> http://bitbucket.org/Littleboy/scummvm-
> jt/src/tip/COMMON%20-%20Add%20annotations%20for%20analysis%20build%20configuration.patch
> \)
> \- Visual Studio 2010 Ultimate or Team System \(create\_project support
> for analysis with VS2005/2008 isn't complete yet\)
> }}}
> {{{#!div style="font-size: 75%"
> Ticket imported from: !#3087828. Ticket imported from: bugs/5431.
> }}}

New description:

 {{{#!Markdown
 Here are the warnings I get when compiling the AGOS engine using Code
 Analysis in VS2010.

 I tried to remove all the obvious false positives. Some warnings look
 suspicious, others are pointing to correct code that still might benefit
 from better error checking.

 d:\sources\scummvm\scummvm\engines\agos\script\_pn.cpp\(894\): warning
 C6011: Dereferencing NULL pointer '\_stackbase'
 d:\sources\scummvm\scummvm\engines\agos\string.cpp\(858\): warning C6011:
 Dereferencing NULL pointer 'ptr' \(looks like a false positive\)
 d:\sources\scummvm\scummvm\engines\agos\verb\_pn.cpp\(188\): warning
 C6011: Dereferencing NULL pointer '\_dragStore'

 Note: If you want to try it yourself, you will need:
 \- the create\_project patch set, along with the WIP code analysis patch
 \(http://bitbucket.org/Littleboy/scummvm-jt/src/942f13a9f24b \)
 \- the following patch to silence some false positives \(
 http://bitbucket.org/Littleboy/scummvm-
 jt/src/tip/COMMON%20-%20Add%20annotations%20for%20analysis%20build%20configuration.patch
 \)
 \- Visual Studio 2010 Ultimate or Team System \(create\_project support
 for analysis with VS2005/2008 isn't complete yet\)
 }}}
 {{{#!div style="font-size: 75%"
 Ticket imported from: !#3087828. Ticket imported from: bugs/5431.
 }}}

--

--
Ticket URL: <https://bugs.scummvm.org/ticket/5431#comment:7>
ScummVM <https://bugs.scummvm.org>
ScummVM