[Scummvm-tracker] [ScummVM] #10800: [Pink] "Pink Panther: Passport to Peril" crashes

[David Turner]

#10800: [Pink] "Pink Panther: Passport to Peril" crashes
-----------------------+--------------------------
  Reporter:  rtentser  |      Owner:  (none)
      Type:  defect    |     Status:  new
  Priority:  normal    |  Component:  Engine: Pink
Resolution:            |   Keywords:
      Game:            |
-----------------------+--------------------------

Comment (by digitall):

 The following patch fixes the issue based on the superclass of
 ActionPlay's onStart method:
 {{{
 diff --git a/engines/pink/objects/actions/action_play.cpp
 b/engines/pink/objects/actions/action_play.cpp
 index fb4f05f0cb..9551f13424 100644
 --- a/engines/pink/objects/actions/action_play.cpp
 +++ b/engines/pink/objects/actions/action_play.cpp
 @@ -64,7 +64,10 @@ void ActionPlay::onStart() {
         int frameCount = _decoder.getFrameCount();
         if (_stopFrame == -1 || _stopFrame >= frameCount)
                 _stopFrame = frameCount - 1;
 -       assert(_startFrame < _decoder.getFrameCount());
 +
 +       if (_startFrame >= _decoder.getFrameCount())
 +               _startFrame = 0;
 +
         ActionCEL::setFrame(_startFrame);
         // doesn't need to decode startFrame here. Update method will
 decode
  }
 }}}

 However, Pink then puts the hamburger back several times i.e. probably an
 error in the value of _endFrame. Not sure if this is the right solution
 and/or whether the repeated loop is due to a different latent issue which
 was hidden by this not working.

--
Ticket URL: <https://bugs.scummvm.org/ticket/10800#comment:3>
ScummVM <https://bugs.scummvm.org>
ScummVM