[Scummvm-tracker] [ScummVM] #10810: Graphics: Return to Launcher changes fullscreen/windowed mode

[sluicebox]

#10810: Graphics: Return to Launcher changes fullscreen/windowed mode
----------------------+----------------------
Reporter:  sluicebox  |      Owner:  (none)
    Type:  defect     |     Status:  new
Priority:  normal     |  Component:  Graphics
Keywords:             |       Game:
----------------------+----------------------
 It would be nice if Return to Launcher didn't change full-screen/windowed
 mode. It doesn't seem intentional and kicks me out of full screen a lot.

 You get kicked out of full screen mode if you:
 1. Start in windowed mode
 2. Switch to full screen with a hotkey
 3. Return to Launcher from a game

 This if happens if the "fullscreen" config setting is false but not if the
 fullscreen setting doesn't exist, which means there's three different
 behaviors: Full screen checked, unchecked, and you've never once used the
 Options screen. The opposite also occurs, if fullscreen=true and you
 switch to window and return to launcher it will switch back to full
 screen.

 This is because setupGraphics() is called again when returning to launcher
 and contains:


 {{{
 if (ConfMan.hasKey("fullscreen"))
         system.setFeatureState(OSystem::kFeatureFullscreenMode,
 ConfMan.getBool("fullscreen"));
 }}}


 It seems like setupGraphics() should only set kFeatureFullscreenMode on
 its first run. I did a quick and dirty patch to try that out and it worked
 for me on Win7.

 For now I just manually delete the fullscreen line from my config file.

--
Ticket URL: <https://bugs.scummvm.org/ticket/10810>
ScummVM <https://bugs.scummvm.org>
ScummVM