[Scummvm-tracker] [ScummVM] #10814: QFG4: Crash in cave when fighting Pit Horror below the tightrope

[Vhati]

#10814: QFG4: Crash in cave when fighting Pit Horror below the tightrope
--------------------------------+-------------------------
  Reporter:  Vhati              |      Owner:  (none)
      Type:  defect             |     Status:  new
  Priority:  normal             |  Component:  Engine: SCI
Resolution:                     |   Keywords:  SCI32
      Game:  Quest for Glory 4  |
--------------------------------+-------------------------

Comment (by Vhati):

 {{{
 (if
   (and
     register
     "(| (SetNowSeen horror) $0001)"
     ...
 }}}
 *squint*
 If SetNowSeen() were expected to return 1/0. And bitwise OR-ing that
 guarantees a 1...

 Did they... Did they microoptimize an action by inserting it into the
 middle of a series of conditions, so it could be short-circuited when the
 register variable was 0?

 When the action did run, always forced to evaluate as 1, it would not
 abandon the block when kernel returned 0.

--
Ticket URL: <https://bugs.scummvm.org/ticket/10814#comment:10>
ScummVM <https://bugs.scummvm.org>
ScummVM