[Scummvm-tracker] [ScummVM] #10814: QFG4: Crash in cave when fighting Pit Horror below the tightrope

[Martin Kiewitz]

#10814: QFG4: Crash in cave when fighting Pit Horror below the tightrope
--------------------------------+-------------------------
  Reporter:  Vhati              |      Owner:  (none)
      Type:  defect             |     Status:  new
  Priority:  normal             |  Component:  Engine: SCI
Resolution:                     |   Keywords:  SCI32
      Game:  Quest for Glory 4  |
--------------------------------+-------------------------

Comment (by m-kiewitz):

 It returns "found", which is defined as a boolean.
 So it's 0 or 1.

 Can you please use "vo 002e:1694" (or whatever the first value is).
 That way you can check what kind of object it is.

 SCI internally uses 16 bit integer, and we added a segment on top to also
 return objects and such (that's ScummVM exclusive) in a way that we can
 distinguish between them.

 Original SCI simply returned either a regular value or an offset, there
 was no way to differentiate between them. It always depends on how the
 value was used later.

 This is not the case for us anymore, because of script bugs like these.
 The original behavior caused memory corruption in some games and other
 random problems and through uninitialized read + the detection above we
 can detect such problems and fix them.

--
Ticket URL: <https://bugs.scummvm.org/ticket/10814#comment:12>
ScummVM <https://bugs.scummvm.org>
ScummVM