[Scummvm-tracker] [ScummVM] #10814: QFG4: Crash in cave when fighting Pit Horror below the tightrope

[Vhati]

#10814: QFG4: Crash in cave when fighting Pit Horror below the tightrope
--------------------------------+-------------------------
  Reporter:  Vhati              |      Owner:  (none)
      Type:  defect             |     Status:  new
  Priority:  normal             |  Component:  Engine: SCI
Resolution:                     |   Keywords:  SCI32
      Game:  Quest for Glory 4  |
--------------------------------+-------------------------

Comment (by Vhati):

 @m-kiewitz:
 > In some cases a workaround may make sense. In other cases the script
 needs to get patched.

 The function definitely needs to run, in preparation for the boundary
 tests.
 The function, wrapped or not, wasn't capable of abandoning the tests.

 The following patch would allow that, make the arithmetic valid, and I
 expect would apply to any of those scripts. Would that be preferred over
 workaround entries?

 {{{
 002e:0404: 78             push1
 002e:0405: 72 ** **       lofsa anyObject
 002e:0408: 36             push
 002e:0409: 43 0a 02 00    callk SetNowSeen[a],  0002
 002e:040d: 36             push      // Make this 0x78 push1
 002e:040e: 35 01          ldi   01
 002e:0410: 14             or        // Result is (1 | 1, true)
 }}}

--
Ticket URL: <https://bugs.scummvm.org/ticket/10814#comment:21>
ScummVM <https://bugs.scummvm.org>
ScummVM