[Scummvm-tracker] [ScummVM] #10814: QFG4: Crash in cave when fighting Pit Horror below the tightrope

[Vhati]

#10814: QFG4: Crash in cave when fighting Pit Horror below the tightrope
--------------------------------+-------------------------
  Reporter:  Vhati              |      Owner:  (none)
      Type:  defect             |     Status:  new
  Priority:  normal             |  Component:  Engine: SCI
Resolution:                     |   Keywords:  SCI32
      Game:  Quest for Glory 4  |
--------------------------------+-------------------------

Comment (by Vhati):

 @m-kiewitz:
 > Is it exactly the same code?

 The idiom is always wrapping SetNowSeen(), given either a named instance
 or a global.

 grep "SetNowSeen" *.sc | grep "|"
 {{{
 n041.sc:        (| (SetNowSeen global185) $0001)
 n041.sc:        (| (SetNowSeen global195) $0001)
 n041.sc:        (| (SetNowSeen global195) $0001)
 n810.sc:        (| (SetNowSeen global185) $0001)
 n830.sc:        (| (SetNowSeen global195) $0001)
 n830.sc:        (| (SetNowSeen revenant) $0001)
 n835.sc:        (| (SetNowSeen global195) $0001)
 n835.sc:        (| (SetNowSeen global195) $0001)
 n835.sc:        (| (SetNowSeen global195) $0001)
 n840.sc:        (| (SetNowSeen global195) $0001)
 n840.sc:        (| (SetNowSeen global195) $0001)
 n855.sc:        (| (SetNowSeen horror) $0001)
 n870.sc:        (| (SetNowSeen global195) $0001)
 n870.sc:        (| (SetNowSeen global195) $0001)
 n870.sc:        (| (SetNowSeen global195) $0001)
 n870.sc:        (| (SetNowSeen nectar) $0001)
 n870.sc:        (| (SetNowSeen global195) $0001)
 }}}
 \\
 Those similar lines are all inserted among if-block conditions.

 In context, the condition preceeding each varies: parameter
 truth/comparisons, global truth/comparisons. In places there are multiple
 instances of the idiom in a row, for different objects.
 \\
 \\
 script 41 - xSlash::doit(), xDuck::doit(), xParryLow::doit()
 script 810 - slash::doit()
 script 830 - revenantForward::doit() twice
 script 835 - doRSlash::doit(), doLSlash::doit(), tailAttack::doit()
 script 840 - doLSlash::doit(), doRSlash::doit()
 script 855 - wipeSpell::doit()
 script 870 - attackLeft::doit(), attackRight::doit(), headAttack::doit(),
 hurtMyself::changeState() twice

--
Ticket URL: <https://bugs.scummvm.org/ticket/10814#comment:37>
ScummVM <https://bugs.scummvm.org>
ScummVM