[Scummvm-tracker] [ScummVM] #10665: Lands of Lore 1 bug which leads to a crash.

digitall trac at scummvm.org
Mon Oct 1 05:09:45 CEST 2018


#10665: Lands of Lore 1 bug which leads to a crash.
----------------------------+--------------------------
  Reporter:  Traveler84     |      Owner:  (none)
      Type:  defect         |     Status:  new
  Priority:  normal         |  Component:  Engine: Kyra
Resolution:                 |   Keywords:
      Game:  Lands of Lore  |
----------------------------+--------------------------

Comment (by digitall):

 Replicated crash from savegame (Use Heal Spell on left fighter, Use them
 to do Freeze Spell on Rock Monster and keep Hitting).

 I re-ran this using Valgrind and this shows invalid memory accesses in one
 of the sound effect loading functions i.e.
 ==21693== Invalid read of size 2
 ==21693==    at 0x2A67D0: Kyra::LoLEngine::snd_playSoundEffect(int, int)
 (endian
 .h:234)
 ==21693==    by 0x2ACAEE:
 Kyra::LoLEngine::chasePartyWithCloseAttacks(Kyra::LoLM
 onster*) (sprites_lol.cpp:1297)
 ==21693==    by 0x2ABF3F:
 Kyra::LoLEngine::updateMonster(Kyra::LoLMonster*) (spr
 ites_lol.cpp:1112)
 ==21693==    by 0x2BB77E: Kyra::LoLEngine::timerProcessMonsters(int)
 (timer_lol.
 cpp:53)
 ==21693==    by 0x2BC638: Common::Functor1Mem<int, void,
 Kyra::LoLEngine>::opera
 tor()(int) const (func.h:451)
 ==21693==    by 0x250B0D: Kyra::TimerManager::update() (timer.cpp:119)
 ==21693==    by 0x264EB4: Kyra::LoLEngine::runLoop() (lol.cpp:889)

 This occurs several times before the segmentation fault i.e.
 ==21693== Invalid read of size 1
 ==21693==    at 0x5A8391: scumm_stricmp(char const*, char const*)
 (str.cpp:1036)
 ==21693==    by 0x2A6894: Kyra::LoLEngine::snd_playSoundEffect(int, int)
 (sound_
 lol.cpp:185)
 ==21693==    by 0x2ACAEE:
 Kyra::LoLEngine::chasePartyWithCloseAttacks(Kyra::LoLM
 onster*) (sprites_lol.cpp:1297)
 ==21693==    by 0x2ABF3F:
 Kyra::LoLEngine::updateMonster(Kyra::LoLMonster*) (spr
 ites_lol.cpp:1112)
 ==21693==    by 0x2BB77E: Kyra::LoLEngine::timerProcessMonsters(int)
 (timer_lol.
 cpp:53)

--
Ticket URL: <https://bugs.scummvm.org/ticket/10665#comment:3>
ScummVM <https://bugs.scummvm.org>
ScummVM


More information about the Scummvm-tracker mailing list