[Scummvm-tracker] [ScummVM] #10397: FULLPIPE: Memory leak when loading a saved game

[digitall]

#10397: FULLPIPE: Memory leak when loading a saved game
------------------------+------------------------------
  Reporter:  dafioram   |      Owner:  (none)
      Type:  defect     |     Status:  new
  Priority:  low        |  Component:  Engine: Fullpipe
Resolution:             |   Keywords:
      Game:  Full Pipe  |
------------------------+------------------------------

Comment (by digitall):

 commit cf1171d4d9b43eba525439da82db16cd4aac0414 is "MOHAWK: RIVEN: Rewind
 videos that are played until their end" from 2018-01-01 18:57:03.

 These memory leaks are still occuring in the current git master, though
 due to code changes / fixes to the Fullpipe engine in the interim, the
 line numbers do not exactly match up from the above trace.

 This is quite tricky to fix as the leakage is occurring from GameVar
 objects created when loading a savegame. These should all be freed
 correctly when exiting, but they are held in a doubly linked list
 structure from which nodes can be deleted and I am not clear in what cases
 when this is done if the node can be deleted/freed.

 This will need some careful and deep analysis of the save / load and
 engine variable code to fix this without accidently freeing actively used
 variables and thus causing crash / breakage.

--
Ticket URL: <https://bugs.scummvm.org/ticket/10397#comment:1>
ScummVM <https://bugs.scummvm.org>
ScummVM