[Scummvm-tracker] [ScummVM] #10732: AGI: Per game volume setting changed (saved!) by ScummVM on game start

[digitall]

#10732: AGI: Per game volume setting changed (saved!) by ScummVM on game start
-----------------------------+-------------------------
  Reporter:  raziel-         |      Owner:  (none)
      Type:  defect          |     Status:  new
  Priority:  normal          |  Component:  Engine: AGI
Resolution:                  |   Keywords:
      Game:  King's Quest 2  |
-----------------------------+-------------------------

Comment (by digitall):

 The relevant code which is causing this issue is here:
 https://github.com/scummvm/scummvm/blob/master/engines/agi/global.cpp#L89
 and
 https://github.com/scummvm/scummvm/blob/master/engines/agi/global.cpp#L136

 I think the issue is that this allows the scripts to override any
 configured setting without thought that the user may have manually
 adjusted this. I think the main culprit are the two lines here:
 https://github.com/scummvm/scummvm/blob/master/engines/agi/global.cpp#L123
 and 124

 If those two lines are commented out, the manually configured settings
 should be respected ... though the script can always override them at
 runtime the changed volume value will not be saved.

--
Ticket URL: <https://bugs.scummvm.org/ticket/10732#comment:1>
ScummVM <https://bugs.scummvm.org>
ScummVM