[Scummvm-tracker] [ScummVM] #10761: SCI: LB2: Disable Speed Test

[sluicebox]

#10761: SCI: LB2: Disable Speed Test
------------------------+------------------------------------------------
Reporter:  sluicebox    |      Owner:  (none)
    Type:  enhancement  |     Status:  new
Priority:  normal       |  Component:  Engine: SCI
Keywords:               |       Game:  Laura Bow 2: The Dagger of Amon-Ra
------------------------+------------------------------------------------
 LB2 has a speed test at the start and I'd like to force it to always set
 the highest results as has been done for other games. I'm submitting a
 script patch that does this. This would solve some minor annoyances.

 First problem is that even when the speed test gets the highest score it
 only initializes the game's detail level to medium instead of highest like
 other sci games. It's lame to have to have to manually set it every time
 and it has immediate effects like how many people and cars are on the
 street.

 Second problem is that I've seen a few times on ios where detail has been
 initialized to lowest due to the speed test doing poorly. It's not every
 time, but presumably on this platform and possibly others there's a lag
 that can occur during screen initialization that overlaps with the speed
 test. Not only is detail unexpectedly initialized to lowest but the test
 score is stored in a global variable that's never updated and used to pace
 the act 5 chase scene which means it can end up going unexpectedly slow.

 Third problem is that the detail slider in the game's control panel
 requires the slider to be placed on the very top-most pixel to count as
 highest (detail level 5) and on touchscreen devices you can't get it that
 high without switching from the default touch mode to drag it up there,
 which is both literally and figuratively a drag.

 The patch I'm submitting ignores the speed test and initializes detail
 level and the cpu speed global to their max values so that everybody
 starts out on highest detail, touchscreen users don't have to bother
 fighting a petulant slider, and no one ends up with an unexpectedly slow
 act 5.

 Test by starting a new game and looking at the detail level or with the
 debugger by querying the game's detail level and cpu score:


 {{{
 send LB2 detailLevel  (floppy versions: send LB2 <noname321>)
 vv g 87
 }}}


 max detail is 5, max cpu is 15

--
Ticket URL: <https://bugs.scummvm.org/ticket/10761>
ScummVM <https://bugs.scummvm.org>
ScummVM