[Scummvm-tracker] [ScummVM] #10780: SCI: GK1: Ego speed bugs in police station & drug store

Martin Kiewitz trac at scummvm.org
Sun Oct 28 12:45:52 CET 2018


#10780: SCI: GK1: Ego speed bugs in police station & drug store
-------------------------------+-------------------------
  Reporter:  sluicebox         |      Owner:  (none)
      Type:  defect            |     Status:  new
  Priority:  normal            |  Component:  Engine: SCI
Resolution:                    |   Keywords:
      Game:  Gabriel Knight 1  |
-------------------------------+-------------------------

Comment (by m-kiewitz):

 Great work as always.

 I added a few comments on the patch.
 Please use SIG_SELECTOR16 for selector values and do not hardcode them.
 There is also SIG_SELECTOR8 for 8 bit IDs. Using that one will create an
 error in case the value does not fit inside a uint8.

 If any of your previous patches also did it like this, please change it
 accordingly.

--
Ticket URL: <https://bugs.scummvm.org/ticket/10780#comment:2>
ScummVM <https://bugs.scummvm.org>
ScummVM


More information about the Scummvm-tracker mailing list