[Scummvm-tracker] [ScummVM :: Bugs] #10873: QFG4 CD: Hero stutters when running

[ScummVM :: Bugs]

#10873: QFG4 CD: Hero stutters when running
--------------------------------+-------------------------
  Reporter:  Vhati              |      Owner:  (none)
      Type:  defect             |     Status:  new
  Priority:  normal             |  Component:  Engine: SCI
Resolution:                     |   Keywords:  SCI32
      Game:  Quest for Glory 4  |
--------------------------------+-------------------------

Comment (by sluicebox):

 This CD-only behavior is due to Sierra upgrading the Cycle classes to
 significantly different after they'd programmed thegame against the
 working ones they shipped in floppy. The stuttering, which bothers me,
 also occurs in the original.

 The grooper/grycler crashes at the inn door and monolith are other
 symptoms, and so is the dial puzzle at the monolith which can't spin a
 full circle anymore because the Cycle classes no longer allow wrapping
 around from a high to low cel value.

 https://github.com/scummvm/scummvm/commit/c1610a9fd1d07c3652509e673be6e111f55df623

 A while ago I investigated the differences to see if I could just patch
 the new motion classes back to the old behavior and fix all this, but
 they're all radically different. It's not just the codepaths, the Game
 class fires things in different orders through different structures,
 events fire in greater magnitudes, and this is software malpractice that
 you don't need decades of hindsight to diagnose. GK1, a SCI32 contemporary
 which is a stable game without motion bugs, used the same classes as QFG4
 floppy in all of its versions with no problems. Proof by example!

 I say there's nothing to be done about this. I'll leave this open for a
 while before closing in case someone else has thoughts. It is indeed a
 bug! That it's a visible regression on every screen tells you how well the
 QFG4CD bug-stomping went.

-- 
Ticket URL: <https://bugs.scummvm.org/ticket/10873#comment:5>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM