[Scummvm-tracker] [ScummVM :: Bugs] #11268: SCI: QFG4: Crash when sliding down slippery slope

[ScummVM :: Bugs]

#11268: SCI: QFG4: Crash when sliding down slippery slope
--------------------------------+-------------------------
  Reporter:  tsoliman           |      Owner:  (none)
      Type:  defect             |     Status:  new
  Priority:  normal             |  Component:  Engine: SCI
Resolution:                     |   Keywords:  sci32
      Game:  Quest for Glory 4  |
--------------------------------+-------------------------
Comment (by sluicebox):

 Please give this a test: https://github.com/scummvm/scummvm/pull/1945

 Be brutal! You have the magic touch on this bug. I just ran it through a
 bunch of stuff and can't break it.

 The previous patch adds a delay, but in your case it's not long enough
 because of the game speed setting. If you increase the speed setting to
 max then it doesn't error. The NRS fan-patch that's included with the GOG
 version also addresses this bug with a delay, but it calculates that delay
 based on the game speed setting. I can't break that one. I could probably
 have just increased the delay in ours but since we already have a proven
 fix in place elsewhere that doesn't rely on any timing and only requires 4
 bytes, I went with that.
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/11268#comment:4>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM