[Scummvm-tracker] [ScummVM :: Bugs] #9646: SCI: QFG1: Running on ice till health points depletion won't kill hero.

[ScummVM :: Bugs]

#9646: SCI: QFG1: Running on ice till health points depletion won't kill hero.
--------------------------------+-------------------------
  Reporter:  OmerMor            |      Owner:  (none)
      Type:  defect             |     Status:  new
  Priority:  normal             |  Component:  Engine: SCI
Resolution:                     |   Keywords:
      Game:  Quest for Glory 1  |
--------------------------------+-------------------------
Comment (by sluicebox):

 I'm putting this bug "on notice" for being closed as WONTFIX if we can't
 come up with something in a reasonable amount of time.

 This is a very real script bug. Omer did a great job in documenting this;
 they called their function that deducted health and then didn't write any
 code to test the return value and handle it, presumably, by calling the
 death function with an appropriate message.

 So what are we to do? Which message should we display when dying? That
 question assumes there's even room to patch in all that new code, which
 we'd have to do twice for the original and the remake, and it's likely
 there's not enough room to do that in either.

 I hope we can fix this! At the same time, I see that QFG1VGA calls
 proc814_19 frequently without testing the return value. I really like this
 game, but it seems like they screwed up basic stat stuff like this all the
 time.
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/9646#comment:5>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM