[Scummvm-tracker] [ScummVM :: Bugs] #9646: SCI: QFG1: Running on ice till health points depletion won't kill hero.

[ScummVM :: Bugs]

#9646: SCI: QFG1: Running on ice till health points depletion won't kill hero.
--------------------------------+-------------------------
  Reporter:  OmerMor            |      Owner:  (none)
      Type:  defect             |     Status:  new
  Priority:  normal             |  Component:  Engine: SCI
Resolution:                     |   Keywords:
      Game:  Quest for Glory 1  |
--------------------------------+-------------------------
Comment (by ZvikaZ):

 I have added a new patching mechanism, hooks to VM, that allows adding new
 instructions.
 It was merged at https://github.com/scummvm/scummvm/pull/2109

 Now engines\sci\engine\vm_hooks.cpp contains a patch that fixes QFG1 (not
 VGA) according to @OmerMor's detailed description.

 However, the question is how do we continue?
 @sluicebox said that there are more scenerios like this at QFG1VGA, so I
 see hear alternatives:
 - go over all these places, and add a patch similar to the one that I
 already did
 - or, patch proc814_19, and if needed, kill the hero from there (instead
 of checking all places that call proc814_19 for return value, and kill him
 if needed). However, maybe there are places that call proc814_19, and the
 hero *shouldn't* die, on purpose?

 Also, it's not clear if there are more problems at legacy QFG1, or is it
 the only one.

 @sluicebox, @OmerMor, I understand that you've already investigated this
 bug, so, what do you think?
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/9646#comment:7>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM