[Scummvm-tracker] [ScummVM :: Bugs] #11457: LSL1 VGA (Russian) freezes when hailing cab

[ScummVM :: Bugs]

#11457: LSL1 VGA (Russian) freezes when hailing cab
-----------------------------------+--------------------------------
  Reporter:  oprion                |      Owner:  sluicebox
      Type:  defect                |     Status:  closed
  Priority:  normal                |  Component:  Engine: SCI
Resolution:  fixed                 |   Keywords:  lsl1sci-ru, freeze
      Game:  Leisure Suit Larry 1  |
-----------------------------------+--------------------------------
Changes (by sluicebox):

 * owner:  (none) => sluicebox
 * status:  new => closed
 * resolution:   => fixed

Comment:

 Fixed in: 93b634fe7ca3995a40bc63325513bcbd682c8ade

 After further investigation, this is indeed a corrupt sound resource. As
 sev said, this is a great candidate for our resource patcher to fix the
 two broken bytes.

 The reason this didn't crash the original is that it would find a matching
 track entry earlier in the list, one that used the correct 0xFF
 terminator, and so it wouldn't get this far. Patching all the terminators
 in this sound to use 0xFE locks up the original. I was wrong about SCI
 Resource Viewer, it only parses the tracks before the broken bytes.

 Thanks again for the report!
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/11457#comment:5>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM