[Scummvm-tracker] [ScummVM :: Bugs] #12410: KEYMAPPER: `SHIFT`+`.` is modified to `.`

[ScummVM :: Bugs]

#12410: KEYMAPPER: `SHIFT`+`.` is modified to `.`
-------------------+---------------------
Reporter:  ZvikaZ  |       Owner:  (none)
    Type:  defect  |      Status:  new
Priority:  normal  |   Component:  Common
 Version:          |  Resolution:
Keywords:          |        Game:
-------------------+---------------------
Description changed by ZvikaZ:

Old description:

> When pressing `SHIFT`+`.` in a game with a parser, such as PQ1 (AGI) or
> SQ3 (SCI), it's treated as if only a `.` was pressed.
>
> If I understand correctly, this is done intentionally - in order to allow
> using `SHIFT`+`.` as a `Skip line` action, for engines that use it, like
> SCUMM.
> However, the `Skip line` action is currently added to all engines, even
> though probably most of them don't use it.
> Thus, engines such as AGI and SCI (and probably others with text parser,
> I haven't checked) have now an unwanted behaviour.
>
> IMO, there are two options here:
> - Give up the functionality of recognizing `SHIFT`+`.` as `.`
> (https://github.com/scummvm/scummvm/pull/2812 attempts to do that, it
> probably can be done in a better way)
> - Don't add `Skip line` to all engines, but only to those that really use
> it (do we know which engines really use it?)
>
> Note: I'm not sure that 'Common' component is accurate, but it's not
> related to one engine or one platform - the issue is in the Keymapper, as
> far as I understand)

New description:

 When pressing `SHIFT`+`.` in a game with a parser, such as PQ1 (AGI) or
 SQ3 (SCI), it's treated as if only a `.` was pressed.

 If I understand correctly, this is done intentionally - in order to allow
 using `SHIFT`+`.` as a `Skip line` action, for engines that use it, like
 SCUMM.
 However, the `Skip line` action is currently added to all engines, even
 though probably most of them don't use it.
 Thus, engines such as AGI and SCI (and probably others with text parser, I
 haven't checked) have now an unwanted behaviour.

 IMO, there are two options here:
 - Give up the functionality of recognizing `SHIFT`+`.` as `.`
 (https://github.com/scummvm/scummvm/pull/2812 attempts to do that, it
 probably can be done in a better way)
 - Don't add `Skip line` to all engines, but only to those that really use
 it (do we know which engines really use it?)

 Note: I'm not sure that 'Common' component is accurate, but it's not
 related to one engine or one platform - the issue is in the Keymapper, as
 far as I understand

--
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/12410#comment:1>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM