[Scummvm-tracker] [ScummVM :: Bugs] #12422: AGS: The Adventures of Fatman - Game crashes before credits

[ScummVM :: Bugs]

#12422: AGS: The Adventures of Fatman - Game crashes before credits
-------------------+--------------------------
Reporter:  joeraz  |       Owner:  dreammaster
    Type:  defect  |      Status:  closed
Priority:  normal  |   Component:  Engine: AGS
 Version:          |  Resolution:  fixed
Keywords:          |        Game:
-------------------+--------------------------
Changes (by dreammaster):

 * owner:  (none) => dreammaster
 * status:  new => closed
 * resolution:   => fixed

Comment:

 Okay, it's all sorted out. This was an interesting bug, that revealed a
 couple of problems.
 1) The agscreditz in that version had a "isFinished" method for detecting
 if the credits scrolling was finished, rather than the
 "IsCreditScrollingFinished" that was present at the time I originally made
 the Black Cauldron remake.
 2) I realized the crash was actually happening because the error method
 "quitprintf" doesn't exit in standalone AGS. It's used frequently
 throughout the codebase, and in this case, it was complaining that the
 roominst wasn't set (because of the missing plugin method), and because
 the quitprintf method exited when it shouldn't, it then proceeded to try
 and call a method on the non-existent roominst, and crashed
 3) Because all calls to quitprintf are now fatal errors, I realised the
 ScummVM version could generate spurious error messages in certain games
 like Fatman, where the script that set the global "abort engine" flag
 still had following stuff.. depending on what happened until the end of
 the game "tick", any number of errors could likely be generated. So I've
 whacked in a bunch of extra abort engine flag checks to break out of the
 script execution immediately. We'll see if any further cases are needed as
 further testing is done.
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/12422#comment:1>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM