[Scummvm-tracker] [ScummVM :: Bugs] #12847: HQ filter broken in HiDPI

ScummVM :: Bugs trac at scummvm.org
Thu Aug 26 14:46:42 UTC 2021


#12847: HQ filter broken in HiDPI
---------------------+-----------------------
Reporter:  tsoliman  |       Owner:  (none)
    Type:  defect    |      Status:  new
Priority:  normal    |   Component:  Graphics
 Version:            |  Resolution:
Keywords:  hidpi     |        Game:
---------------------+-----------------------
Comment (by criezy):

 This is not really a regression in that the current behaviour matches the
 behaviour in the last release.

 The work on HiDPI has added the ability to scale the GUI. This was meant
 to be used primarily for HiDPI displays, but there were several
 intermediate steps with different ways to scale the GUI that had
 unintended consequences. What you see in your screenshots is one of those.

 I suspect that changes that "breaks" that (and restores the 2.2.0
 behaviour) is ad31dfc8d5. Before that commit the GUI was clipped to a
 resolution of 960x720 max, with a scaling applied to match the window size
 if greater than that. This was not optimal in the launcher where having a
 higher resolution for the GUI can be welcome, and it also had a few others
 quirks and unexpected behaviour.

 The good news is that all this work to support HiDPI does mean that we can
 now scale the GUI, so it might not be too complicated to improve on the
 current behaviour. But I see this has an enhancement rather than bug fix,
 and I am not sure I would say the current behaviour is broken.

 We could for example try to scale the GUI according to the original game
 resolution when displaying GUI dialogs in games. But that might not work
 that well for 320x200 games for example.

 > Note that this "giant window" effect happens in any HQ filter mode (2x
 or 3x) but not in normal 3x scaling

 I am confused by this statement. Could you clarify what this means?
 I just made a series of tests on macOS with current master and the
 behaviour is the same for me for both Normal 3x and Hq 3x (and I also
 checked it is consistent with the way it behaved in the 2.2.0 release). I
 also do not see any reason why HQ scalers would behave differently from
 Normal scalers.
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/12847#comment:5>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM


More information about the Scummvm-tracker mailing list