[Scummvm-tracker] [ScummVM :: Bugs] #12864: AGS: Crash making in-game saves in Strangeland

[ScummVM :: Bugs]

#12864: AGS: Crash making in-game saves in Strangeland
------------------------+--------------------------
Reporter:  dreammaster  |       Owner:  (none)
    Type:  defect       |      Status:  new
Priority:  normal       |   Component:  Engine: AGS
 Version:               |  Resolution:
Keywords:               |        Game:
------------------------+--------------------------
Comment (by criezy):

 Yes, there is something weird. It seems it is trying to both use a
 subdirectory, and not use one:
 {{{
 ResolveScriptPath($SAVEGAMEDIR$/save2_test.dat)
 ResolveScriptPath($SAVEGAMEDIR$/test/save2_test.dat)
 }}}

 I am not sure if this is something in our code, or if the original does
 that as well. It could try using a subdirectory only if it fails
 reading/writing without one for example...

 In any case flattening paths ensure we are not going to assert if some
 games really try to do it (even if Strangeland doesn't), so I made the
 commit (and it was only a one line change).

 However while saving and loading seems to work if I reload the game in the
 same session, this still does not work when closing the game and
 restarting. I suspect this is because we do not support the `kFile_Write`
 mode and always treat it as `kFile_CreateAlways`, which means that it
 replaces the file if is already exists instead of opening it in append
 mode or read-write mode. This may be why the strangeland-list.slot file,
 which contains a list of the saved games, seems to be cleared when closing
 and restarting the game.
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/12864#comment:4>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM