[Scummvm-tracker] [ScummVM :: Bugs] #13133: TWINE: LBA1 DotEmu Enhanced (Steam) play wrong midi tracks

[ScummVM :: Bugs]

#13133: TWINE: LBA1 DotEmu Enhanced (Steam) play wrong midi tracks
---------------------------------+---------------------------------
Reporter:  antoniou79            |      Owner:  (none)
    Type:  defect                |     Status:  new
Priority:  normal                |  Component:  Engine: TwinE
 Version:                        |   Keywords:  Dotemu, Steam, midi
    Game:  Little Big Adventure  |
---------------------------------+---------------------------------
 Tested on Windows 10 x64, latest 64bit build from master and also on local
 build.

 It seems that for cd music (like the one in the starting menu screen), the
 engine plays the correct track --as far as I've seen, the ScummVM engine
 already offsets the track id in order to play the correct track from the
 available mp3 (or ogg) files that the Steam / DotEmu release includes.

 This is not done for the midi tracks and it seems that it should also be
 done there. As is, the wrong midi tracks seems to be playing. For example,
 wrong midi tracks play for the Adeline logo, and also starting a new game
 (at the prison map). In fact these track's id are again offset by one (1)
 from the ones that should play.

 The following edit in music.cpp seems to fix the issue, but I'd rather
 someone more familiar with the engine looks into it too.

 Current line:
 https://github.com/scummvm/scummvm/blob/bb340c3b2b46242a77891b34fcf6dfe9436f386f/engines/twine/audio/music.cpp#L249

 modified line:
 {{{
 const Common::String &trackName = Common::String::format("lba1-%02i",
 midiIdx + 1);
 }}}
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/13133>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM