[Scummvm-tracker] [ScummVM :: Bugs] #13151: When global setting is Speech, subtitles don't appear to games without speech

[ScummVM :: Bugs]

#13151: When global setting is Speech, subtitles don't appear to games without
speech
-------------------+------------------------
Reporter:  orgads  |       Owner:  sluicebox
    Type:  defect  |      Status:  pending
Priority:  normal  |   Component:  Common
 Version:          |  Resolution:  assigned
Keywords:          |        Game:
-------------------+------------------------
Comment (by sluicebox):

 I'm missing something; I'm unable to reproduce and I'm not seeing how this
 wouldn't mean there weren't already problems like this before the UI
 change.

 Can you walk me through exact UI steps to reproduce this, starting with an
 empty scummvm.ini? The new Windows Portable Mode means you can just `touch
 scummvm.ini` in your exe directory and start experimenting, which is what
 I've been doing. You could attach that once you've got it in a broken
 state.

 What games are you using? Are you seeing this in any engine besides SCUMM?
 I've been trying with a floppy version of Sam N Max since that's
 GUIO_NOSPEECH. I made the dialog change to fix an SCI GUIO_NOSPEECH game,
 so it seems likely this is engine-specific.

 My commit changed the Edit Game dialog so that when the subtitle controls
 are disabled (such as for GUIO_NOSPEECH games) and changes are applied,
 "subtitles" and "speech_mute" keys are removed from the game-level config.
 This is consistent with the other UI code and fixed a bug where those
 config values were being set based on (undefined?) invisible state from
 disabled UI widgets. If the absence of those two keys from game-level
 config breaks subtitles... then shouldn't games have already been broken
 before the change? Adding GUIO_NOSPEECH games through the UI without
 changing defaults didn't set "subtitles" or "speech_mute". (That is, that
 was the behavior before and after the commit.)

 Let's get this reproducing first, but might need to bring in a SCUMM
 expert.
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/13151#comment:3>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM