[Scummvm-tracker] [ScummVM :: Bugs] #11038: SCI: SQ4: Entering skate-o-rama incompletable at slower speeds (CD only)

[ScummVM :: Bugs]

#11038: SCI: SQ4: Entering skate-o-rama incompletable at slower speeds (CD only)
---------------------+----------------------------
Reporter:  TheQL     |       Owner:  sluicebox
    Type:  defect    |      Status:  new
Priority:  normal    |   Component:  Engine: SCI
 Version:            |  Resolution:
Keywords:  original  |        Game:  Space Quest 4
---------------------+----------------------------
Comment (by sluicebox):

 I give up on this one; I'll see if someone can remove me as the 'owner'
 since that's not a UI option anymore.

 NRS' solution is unsurprisingly the best: converting each Script object's
 delay in cycles to a delay in ticks and multiplying that by the game
 speed. That in conjunction with our extra throttling in these rooms gets
 things back to intended behavior from floppy where the delays are relative
 to game speed, while still being able to see the lasers when speed is set
 to high.

 The problem with patching the cycle delays is that there's over forty of
 them in the four rooms. That's not the deal breaker, there's room for the
 new bytes. The big problem is that the bytecode signature is so small that
 there aren't four consecutive constant bytes needed for SIG_MAGICDWORD. If
 this can't be done with three little generic patches then the alternatives
 become, in my opinion, very big and messy and out of proportion to the
 problem. And at that point you're really committed to stamping out all the
 edge cases in these rooms, and they sure have them, so it just gets
 messier. Our existing throttling solves the biggest problems and I'm okay
 with "turn up the speed like in the original." (or, use NRS' SQ4 Update!)
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/11038#comment:11>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM