[Scummvm-tracker] [ScummVM :: Bugs] #12173: Broken Sword 2.5 crash

[ScummVM :: Bugs]

#12173: Broken Sword 2.5 crash
----------------------+------------------------
Reporter:  RetroJaro  |       Owner:  (none)
    Type:  defect     |      Status:  new
Priority:  normal     |   Component:  --Unset--
 Version:             |  Resolution:
Keywords:             |        Game:
----------------------+------------------------
Comment (by criezy):

 I have identified the issue.

 When `PackageManager::loadDirectoryAsPackage()` gets called it sets the
 `_extractedFiles` flag to true, which indicates that we are playing the
 game with extracted files.

 Then in `PackageManager::doSearch` when it iterates on items in the
 `ArchiveMemberList`, if we are playing with extracted files there is a
 block where it assumes the `ArchiveMember` are `FSNode`.

 The issue here is that when we are playing with the non-extracted game,
 the `PackageManager::loadDirectoryAsPackage()` function still gets called
 when we load or save a game with the savegame path. And as a result after
 we have saved or loaded a savegame, it thinks we are playing with
 extracted files. And then it crashes when trying to access `ArchiveMember`
 as `FSNode`, because they are not actually a `FSNode`.
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/12173#comment:5>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM