[Scummvm-tracker] [ScummVM :: Bugs] #11758: PEGASUS: colossal memory leak, wan't start

ScummVM :: Bugs trac at scummvm.org
Mon Feb 22 18:11:42 UTC 2021


#11758: PEGASUS: colossal memory leak, wan't start
-----------------------+-----------------------------------------------
Reporter:  fedor4ever  |       Owner:  fedor4ever
    Type:  defect      |      Status:  closed
Priority:  high        |   Component:  Engine: Pegasus
 Version:              |  Resolution:  fixed
Keywords:              |        Game:  Journeyman Project Pegasus Prime
-----------------------+-----------------------------------------------
Comment (by criezy):

 Thanks for testing and confirming this is the source of the issue.
 But actually the change here is probably not what we want to do (but
 opening a pull request could allow to move the discussion there).

 Eugene, do you have a suggestion to fix this issue without breaking
 loading macbinary data from ISOBuster? Would the following work to are the
 check stricter?
 {{{
 if (MBI_INFOHDR + dataSizePad + rsrcSizePad == (uint32)stream.size() ||
     MBI_INFOHDR + dataSizePad + rsrcSize == (uint32)stream.size()) {
     resForkOffset = MBI_INFOHDR + dataSizePad;
 }

 }}}
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/11758#comment:19>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM


More information about the Scummvm-tracker mailing list