[Scummvm-tracker] [ScummVM :: Bugs] #12189: EOB2 short sword "Sting" regression in v2.2.0

[ScummVM :: Bugs]

#12189: EOB2 short sword "Sting" regression in v2.2.0
----------------------------------+--------------------------
Reporter:  mprobinson             |      Owner:  (none)
    Type:  defect                 |     Status:  new
Priority:  normal                 |  Component:  Engine: Kyra
 Version:                         |   Keywords:
    Game:  Eye of the Beholder 2  |
----------------------------------+--------------------------
 Language: English
 Version: DOS (GOG.com version)
 OS: Debian Unstable x86_64

 In version v2.2.0, if you attempt to pick up the item 'Short Sword
 "Sting"', it vanishes and the message "YOU MAY ONLY EAT FOOD!" appears. In
 previous versions it could be picked up normally. The short sword is found
 in Catacomb Level 2, location 15 on the Clue Book map (the big room to the
 north with a lot of Skeleton Warriors). The sword is not necessary to
 complete the game, but it is the second-best offhand weapon in the game,
 so it is disappointing to have it vanish. I attached a save file with the
 sword ready to pick up.

 I bisected the bug to commit fcad95af09e61dbd401e2a3c0729d7def99d3e24,
 "KYRA: (EOB/SegaCD) - add level map function".

 I believe the bug is in scummvm/engines/kyra/gui/gui_eob.cpp, line 946 in
 current HEAD, line 933 in the first bad commit, starting:

                 if (_items[d].nameUnid == 97) {

 This code appears to handle EOB/SegaCD maps, but it does not check which
 game is currently running, so the EOB2 short sword is mistaken for an
 EOB/SegaCD map item.
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/12189>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM