[Scummvm-tracker] [ScummVM :: Bugs] #12055: BACKEDS: strange code in sdl-events.cpp
ScummVM :: Bugs
trac at scummvm.org
Sat Jan 9 12:49:02 UTC 2021
#12055: BACKEDS: strange code in sdl-events.cpp
-----------------------+-----------------------
Reporter: fedor4ever | Owner: (none)
Type: defect | Status: new
Priority: normal | Component: --Other--
Version: | Keywords:
Game: |
-----------------------+-----------------------
This code present till commit 7de9982 from line 178. Code smells bad. Why
used dynamic_cast? It's unsafe and lower perfomance.
{{{
if (_graphicsManager) {
if (dynamic_cast<SdlGraphics3dManager
*>(_graphicsManager)) {
dynamic_cast<SdlGraphics3dManager
*>(_graphicsManager)->notifyMousePosition(event.mouse);
} else if (dynamic_cast<SdlGraphicsManager
*>(_graphicsManager)) {
dynamic_cast<SdlGraphicsManager
*>(_graphicsManager)->notifyMousePosition(event.mouse);
}
}
}}}
--
Ticket URL: <https://bugs.scummvm.org/ticket/12055>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM
More information about the Scummvm-tracker
mailing list