[Scummvm-tracker] [ScummVM :: Bugs] #12713: STARTREK enable alternative path for voc files

[ScummVM :: Bugs]

#12713: STARTREK enable alternative path for voc files
----------------------------+-------------------------------
Reporter:  Retro64          |       Owner:  (none)
    Type:  feature request  |      Status:  new
Priority:  normal           |   Component:  Engine: Startrek
 Version:                   |  Resolution:
Keywords:                   |        Game:
----------------------------+-------------------------------
Description changed by Retro64:

Old description:

> When installing the GOG version or browsing the CD version, the voc
> folder is on the same level as the language folders. All localizations
> access this parent folder in order to use use the same voc files.
> Currently the engine searches - naturally - for the voc files in the root
> folder of each language. For sure the files can be copied redundant into
> each folder or a symlink might be used within *NIX systems to get rid of
> the redundant files, but an option to search the parent folder for voc
> folder or a config options to configure the path to the voc folders might
> be a useful feature for multi-language game support.
>
> One - hacky - way would be a change in
> https://github.com/scummvm/scummvm/blob/cbe20d11553f8ca2f83084aa0fcf0547022dc5fb/engines/startrek/sound.cpp
>
> {{{
> else if (!SearchMan.hasFile("voc/speech.mrk")) {
> ->
> // Defined in namespace
> var vocPath = "voc";
> ...
>
> else if (!SearchMan.hasFile("voc/speech.mrk" &&
> !SearchMan.hasFile("../voc/speech.mrk"))) {
> ...
> }
>
> if (SearchMan.hasFile("../voc/speech.mrk")) {
>   vocPath = "../voc";
> }
>
> // All absolute paths "voc" need to be replaced by vocPath
> }}}
>
> For sure the different path leads to different absolute paths within the
> file

New description:

 When installing the GOG version or browsing the CD version, the voc folder
 is on the same level as the language folders. All localizations access
 this parent folder in order to use use the same voc files. Currently the
 engine searches - naturally - for the voc files in the root folder of each
 language. For sure the files can be copied redundant into each folder or a
 symlink might be used within *NIX systems to get rid of the redundant
 files, but an option to search the parent folder for voc folder or a
 config options to configure the path to the voc folders might be a useful
 feature for multi-language game support.

 One - hacky - way would be a change in
 https://github.com/scummvm/scummvm/blob/cbe20d11553f8ca2f83084aa0fcf0547022dc5fb/engines/startrek/sound.cpp

 {{{
 else if (!SearchMan.hasFile("voc/speech.mrk")) {
 ->
 // Defined in namespace
 var vocPath = "voc";
 ...

 else if (!SearchMan.hasFile("voc/speech.mrk" &&
 !SearchMan.hasFile("../voc/speech.mrk"))) {
 ...
 }

 if (SearchMan.hasFile("../voc/speech.mrk")) {
   vocPath = "../voc";
 }

 // All absolute paths "voc" need to be replaced by vocPath
 }}}

 Paths to be adjusted:

 https://github.com/scummvm/scummvm/blob/cbe20d11553f8ca2f83084aa0fcf0547022dc5fb/engines/startrek/sound.cpp#L217

 https://github.com/scummvm/scummvm/blob/cbe20d11553f8ca2f83084aa0fcf0547022dc5fb/engines/startrek/sound.cpp#L252

--
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/12713#comment:4>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM