[Scummvm-tracker] [ScummVM :: Bugs] #12567: PRIVATE: Opening Safe causes ScummVM crash

[ScummVM :: Bugs]

#12567: PRIVATE: Opening Safe causes ScummVM crash
------------------------------+------------------------------
Reporter:  TrivialBalderdash  |       Owner:  neuromancer
    Type:  defect             |      Status:  new
Priority:  normal             |   Component:  Engine: Private
 Version:                     |  Resolution:
Keywords:                     |        Game:  Private Eye
------------------------------+------------------------------
Comment (by TrivialBalderdash):

 Great update. I tested both opening the safe (success!) and tripping the
 alarm before leaving (no crash).

 There was something I noticed that got me testing a little further.  I
 tried multiple times to open the safe with the correct combination, paying
 attention to when the police would arrive.  I also went to other scenes
 where the police would arrive, like a second visit to Idaho Street.

 As you mentioned in another ticket, it's based on the number of clicks.
 If I'm following the code correctly, both the siren and police arrival are
 not tied together and are not going to be the same every time (random
 number & police index will change).

 What I wanted to ask about - **what is counted as a click?**
 On original hardware, it seems that only hotspots are counted (navigation
 arrows and searching).  On my 486 PC, I can click dozens of times on a
 non-hotspot and nothing will happen.  In ScummVM, it seems that all clicks
 are counted.  I tested this in several locations - Idaho Street,
 Steelgrave's Mansion, Van Nuys Hotel.

 **This makes absolutely no difference during the game, except for opening
 the safe.**  It takes 16 clicks to navigate to and open the safe (3 to
 move to and open the painting, 12 to turn the dials from 0,0,0, and 1 more
 to pull the handle).  This will almost always trigger the police arrival
 in ScummVM.

 Of course, I can't be 100% sure about this, but I don't think original
 hardware counts turning the safe digits in the click count.  I tried 30-40
 clicks turning numbers and it never triggered the police.

 I'm not sure if this is an issue or not, but I thought I'd ask you.
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/12567#comment:6>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM