[Scummvm-tracker] [ScummVM :: Bugs] #12723: AGS: Captain Disaster in Death Has a Million Stomping Boots - Crash when talking to speeder saleswoman

[ScummVM :: Bugs]

#12723: AGS: Captain Disaster in Death Has a Million Stomping Boots - Crash when
talking to speeder saleswoman
-------------------+--------------------------
Reporter:  joeraz  |       Owner:  dreammaster
    Type:  defect  |      Status:  closed
Priority:  normal  |   Component:  Engine: AGS
 Version:          |  Resolution:  outdated
Keywords:          |        Game:
-------------------+--------------------------
Changes (by dreammaster):

 * owner:  (none) => dreammaster
 * status:  new => closed
 * resolution:   => outdated

Comment:

 I presume that this was using an old savegame rather than starting from
 scratch. At the time I first did the conversion of the AGS codebase, it
 was in a very inconsistent/unstable state.. a bunch of stuff was
 accidentally committed and then reverted. This looks like another case of
 that. In the ScriptDrawingSurface::Serialize method, the bad original code
 I imported into ScummVM had this:
         SerializeInt((roomBackgroundNumber & 0xFFFF) | (roomMaskType <<
 16));

 whereas, the proper line in the cleaned up codebase I re-imported a few
 weeks ago had this:
         SerializeInt(roomBackgroundNumber);

 The result is that the room number of -1 was accidentally saved as 65535,
 and is being incorrectly loaded as such even with the new codebase. I
 tried starting the game from scratch, and was able to verify that there
 wasn't any problem anymore of saving/loading the game and then talking to
 the speeder woman.
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/12723#comment:1>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM