[Scummvm-tracker] [ScummVM :: Bugs] #12730: AGS: Crash when starting Kathy Rain

[ScummVM :: Bugs]

#12730: AGS: Crash when starting Kathy Rain
-------------------+-------------------------
Reporter:  criezy  |      Owner:  (none)
    Type:  defect  |     Status:  new
Priority:  normal  |  Component:  Engine: AGS
 Version:          |   Keywords:
    Game:          |
-------------------+-------------------------
 When starting Kathy Rain I get a crash with a buffer overflow:
 {{{
 ==6016==ERROR: AddressSanitizer: heap-buffer-overflow on address
 0x00011677c7b8 at pc 0x0001005d9198 bp 0x00016f98fe00 sp 0x00016f98fdf8
 READ of size 1 at 0x00011677c7b8 thread T0
     #0 0x1005d9194 in AGS3::utf8_getc(char const*) unicode.cpp:59
     #1 0x1005dead0 in AGS3::ustrlwr(char*) unicode.cpp:1143
     #2 0x100995640 in AGS3::StrContains(char const*, char const*)+0x68
 (scummvm:arm64+0x10052d640)
     #3 0x100997638 in AGS3::Sc_StrContains(void*, AGS3::RuntimeScriptValue
 const*, int)+0x210 (scummvm:arm64+0x10052f638)
     #4 0x100ae3e98 in AGS3::ccInstance::Run(int) cc_instance.cpp:1007
     #5 0x100adcad0 in AGS3::ccInstance::CallScriptFunction(char const*,
 int, AGS3::RuntimeScriptValue const*) cc_instance.cpp:340
     #6 0x100aff8fc in AGS3::RunScriptFunctionIfExists(AGS3::ccInstance*,
 char const*, int, AGS3::RuntimeScriptValue const*) script.cpp:365
     #7 0x100afe478 in AGS3::RunTextScript(AGS3::ccInstance*, char const*)
 script.cpp:414
     #8 0x100a9f1f4 in AGS3::start_game() game_start.cpp:88
     #9 0x100a9f7f0 in AGS3::initialize_start_and_play_game(int, int)
 game_start.cpp:124
     #10 0x100a817e4 in
 AGS3::initialize_engine(AGS3::std::map<AGS3::AGS::Shared::String,
 AGS3::std::map<AGS3::AGS::Shared::String, AGS3::AGS::Shared::String,
 Common::Less<AGS3::AGS::Shared::String> >,
 Common::Less<AGS3::AGS::Shared::String> > const&) engine.cpp:1247
     #11 0x10057a21c in AGS::AGSEngine::run() ags.cpp:183
 }}}

 This is with up to date code from master on macOS. The game is from Steam.
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/12730>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM