[Scummvm-tracker] [ScummVM :: Bugs] #10732: AGI: Per game volume setting changed (saved!) by ScummVM on game start

[ScummVM :: Bugs]

#10732: AGI: Per game volume setting changed (saved!) by ScummVM on game start
--------------------+-----------------------------
Reporter:  raziel-  |       Owner:  (none)
    Type:  defect   |      Status:  new
Priority:  normal   |   Component:  Engine: AGI
 Version:           |  Resolution:
Keywords:           |        Game:  King's Quest 2
--------------------+-----------------------------
Comment (by digitall):

 @m-kiewitz: "We could also disable volume setting at the start of the game
 everywhere.
 Oh well I see that it already got merged, so meh."

 That would be another option, but your workaround for the fangames works
 fine. The issue is that a few of the detection entries for various
 fangames were using the wrong macro i.e. GAME rather than FANGAME macro
 and while they had the gameid set for fangame, they didn't manually set
 the fangame feature flag i.e. GF_FANMADE which is being used to enable the
 workaround... hence audio was still broken.

 The fan game detection is still required, but the issue is that the
 detection entries should be cleaned up a bit. While the macros there are
 for readability of the detection entries, there are too many layers of
 indirection. It would be clearer with just one layer of macros so that it
 is clear that all the fangames are being flagged correctly.
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/10732#comment:16>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM