[Scummvm-tracker] [ScummVM :: Bugs] #12515: AGS: Mac Steam games not detected when user selects .app file

[ScummVM :: Bugs]

#12515: AGS: Mac Steam games not detected when user selects .app file
-------------------------+--------------------------
Reporter:  Thunderforge  |       Owner:  (none)
    Type:  defect        |      Status:  new
Priority:  normal        |   Component:  Engine: AGS
 Version:                |  Resolution:
Keywords:  steam         |        Game:
-------------------------+--------------------------
Description changed by Thunderforge:

Old description:

> When a Mac user tries to add a LucasArts game on Steam, they can navigate
> to the `.app` file and ScummVM will detect the game. But when a Mac user
> tries to add an AGS game on Steam, navigating to the `.app` file results
> in ScummVM saying that no game can be found.
>
> == Expected Behavior
>
> The user should be able to select the `.app` file for either file and
>
> == Current Behavior
>
> ScummVM detects, for instance, `The Fate of Atlantis.app` but not
> `KathyRain.app`.
>
> == Reproduction
>
> See also the attached animated GIF.
>
> 1. Launch a version of ScummVM that supports AGS games (tested with 5 May
> build)
> 1. Click "Add Game"
> 1. Navigate to `~/Library/Application Support/Steam/SteamApps/common`
>
> === LucasArts game: Expected Behavior
>
> 1. Open the folder of a LucasArts game (such as ''Indiana Jones and the
> Fate of Atlantis''), select the application within, and click the
> "Choose" button.
> 1. You will see that ScummVM recognizes the game.
>
> Tested with ''Indiana Jones and the Fate of Atlants'', ''Indiana Jones
> and the Last Crusade'', ''Loom'', and ''The Dig''.
>
> === AGS game: Current Behavior
>
> 1. Open the folder of an AGS game (such as ''Kathy Rain''), select the
> application within, and click the "Choose" button.
> 1. A dialog will appear saying "ScummVM could not find any game in the
> specified directory!"
>
> Tested with ''Kathy Rain'' and ''Whispers of a Machine''.
>
> === AGS game: Workaround
>
> 1. Open the folder of an AGS game (such as ''Kathy Rain''), select the
> application within
> 1. Expand the "folder" of the application and navigate to
> `Contents/Resources`
> 1. Click the "Choose" button
> 1. The game is recognized by ScummVM
>
> Thus the issue is not that ScummVM doesn't know about the game, it's that
> it doesn't treat the Mac Steam version of the game the same way as it
> does the Mac Steam versions of the LucasArts games.
>
> (As an implementation issue: perhaps ScummVM should recognize that if
> this is a Mac and the "folder" ends in `.app`, then it should know to
> check for the existence of the necessary files in `Contents/Resources`
> before giving up).

New description:

 When a Mac user tries to add a LucasArts game on Steam, they can navigate
 to the `.app` file and ScummVM will detect the game. But when a Mac user
 tries to add an AGS game on Steam, navigating to the `.app` file results
 in ScummVM saying that no game can be found.

 == Expected Behavior

 The user should be able to select the `.app` file for the Mac Steam
 version of any recognized game.

 == Current Behavior

 ScummVM detects, for instance, `The Fate of Atlantis.app` but not
 `KathyRain.app`.

 == Reproduction

 See also the attached animated GIF.

 1. Launch a version of ScummVM that supports AGS games (tested with 5 May
 build)
 1. Click "Add Game"
 1. Navigate to `~/Library/Application Support/Steam/SteamApps/common`

 === LucasArts game: Expected Behavior

 1. Open the folder of a LucasArts game (such as ''Indiana Jones and the
 Fate of Atlantis''), select the application within, and click the "Choose"
 button.
 1. You will see that ScummVM recognizes the game.

 Tested with ''Indiana Jones and the Fate of Atlants'', ''Indiana Jones and
 the Last Crusade'', ''Loom'', and ''The Dig''.

 === AGS game: Current Behavior

 1. Open the folder of an AGS game (such as ''Kathy Rain''), select the
 application within, and click the "Choose" button.
 1. A dialog will appear saying "ScummVM could not find any game in the
 specified directory!"

 Tested with ''Kathy Rain'' and ''Whispers of a Machine''.

 === AGS game: Workaround

 1. Open the folder of an AGS game (such as ''Kathy Rain''), select the
 application within
 1. Expand the "folder" of the application and navigate to
 `Contents/Resources`
 1. Click the "Choose" button
 1. The game is recognized by ScummVM

 Thus the issue is not that ScummVM doesn't know about the game, it's that
 it doesn't treat the Mac Steam version of the game the same way as it does
 the Mac Steam versions of the LucasArts games.

 (As an implementation issue: perhaps ScummVM should recognize that if this
 is a Mac and the "folder" ends in `.app`, then it should know to check for
 the existence of the necessary files in `Contents/Resources` before giving
 up).

--
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/12515#comment:1>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM