[Scummvm-tracker] [ScummVM :: Bugs] #12513: MOHAWK: Static in Myst Sounds (GOG ME Release)

ScummVM :: Bugs trac at scummvm.org
Thu May 20 01:07:18 UTC 2021


#12513: MOHAWK: Static in Myst Sounds (GOG ME Release)
---------------------+-----------------------------
Reporter:  squigley  |       Owner:  digitall
    Type:  defect    |      Status:  pending
Priority:  normal    |   Component:  Engine: Mohawk
 Version:            |  Resolution:  outdated
Keywords:            |        Game:  Myst
---------------------+-----------------------------
Comment (by digitall):

 @squigley: OK. Thanks for confirming.

 I have had a look at the modified wave.cpp provided by ctoroman and it is
 basically the state of wave.cpp prior to the following commit (but with a
 few spurious white space changes and minor bits leftover as well):
 https://github.com/scummvm/scummvm/commit/fed5608e439e9e60a454e06fa27246ea5844bf9d

 That commit migrated the wave decoder to using substream rather than
 locally manually allocating memory buffers so probably is the cause of the
 issue i.e. if it deallocates
 before it should, invalid memory could be played i.e. static.

 It is possible that the later
 https://github.com/scummvm/scummvm/commit/4ea4627b1187b343ed95da8fcaa9d5292e9d0217
 change is also causing this.

 Since you can compile your own git version, I would suggest trying
 bisecting for this using git-bisect to confirm... or just manually trying
 the commit prior to fed5608 and fed5608 to see if this is the cause.
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/12513#comment:6>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM


More information about the Scummvm-tracker mailing list