[Scummvm-tracker] [ScummVM :: Bugs] #13101: SHERLOCK: Game crashes lightning matches on lab table

[ScummVM :: Bugs]

#13101: SHERLOCK: Game crashes lightning matches on lab table
-------------------------+-------------------------------------------------
Reporter:  popovi76      |       Owner:  (none)
    Type:  defect        |      Status:  new
Priority:  normal        |   Component:  Engine: Sherlock
 Version:                |  Resolution:
Keywords:                |        Game:  Sherlock Holmes: Case of the
                         |  Serrated Scalpel
-------------------------+-------------------------------------------------
Comment (by eriktorbjorn):

 These are the dimensions of the frames that the engine tries to load:

 {{{
 59MATCH4.vgs: 53x98
 59MATCH4.vgs: 53x97
 59MATCH4.vgs: 53x101
 59MATCH4.vgs: 53x105
 59MATCH4.vgs: 53x95
 59MATCH4.vgs: 58x83
 59MATCH4.vgs: 67x74
 59MATCH4.vgs: 69x78
 59MATCH4.vgs: 63x68
 59MATCH4.vgs: 55x65
 59MATCH4.vgs: 47x59
 59MATCH4.vgs: 37x52
 59MATCH4.vgs: 26x39
 59MATCH4.vgs: 0x26
 59MATCH4.vgs: 2348x0         <-- This is the last frame that's actually
 drawn
 59MATCH4.vgs: 0x0
 59MATCH4.vgs: 0x0
 59MATCH4.vgs: 0x18944
 59MATCH4.vgs: 0x0
 59MATCH4.vgs: 0x0
 59MATCH4.vgs: 0x0
 59MATCH4.vgs: 0x0
 59MATCH4.vgs: 0x0
 59MATCH4.vgs: 0x0
 59MATCH4.vgs: 0x0
 59MATCH4.vgs: 0x0
 59MATCH4.vgs: 0x0
 59MATCH4.vgs: 45641x0        <-- This is the frame that causes the crash
 59MATCH4.vgs: 0x0
 59MATCH4.vgs: 0x0
 59MATCH4.vgs: 18761x25165    <-- This frame probably caused the delay
 earlier
 59MATCH4.vgs: 53x98
 }}}

 So it is trying to draw some bad frames, but that doesn't cause any
 graphical glitches that I can see so it's probably harmless.

 The real harm comes from the engine trying to decode some even worse
 frames. So I guess one way would be to have it decode the frames on
 demand, rather than in advance. I'm going to attach a proof-of-concept
 patch for doing that.
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/13101#comment:4>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM