[Scummvm-tracker] [ScummVM :: Bugs] #13114: SQ3: v1.018 "COURSE ALREADY ACHIEVED" not displaying (was: Space Quest III v1.018 Report a Bug)

[ScummVM :: Bugs]

#13114: SQ3: v1.018 "COURSE ALREADY ACHIEVED" not displaying
-------------------+----------------------------
Reporter:  Thpwg   |       Owner:  (none)
    Type:  defect  |      Status:  new
Priority:  normal  |   Component:  Engine: SCI
 Version:          |  Resolution:
Keywords:          |        Game:  Space Quest 3
-------------------+----------------------------
Changes (by sluicebox):

 * summary:  Space Quest III v1.018 Report a Bug => SQ3: v1.018 "COURSE
     ALREADY ACHIEVED" not displaying

Comment:

 Hello! This is interesting, thanks for reporting it and including the
 version number. This is the result of a script change that's in later
 versions which prevents something confusing but the change is a little
 hacky.

 To restate the problem: In 1.018, on the navigation screen (room 19) when
 setting a course to the sector you're already in, the original displays
 the text "COURSE ALREADY ACHIEVED" in the upper right corner *very
 briefly* as the screen transitions back to the main control panel (room
 17). In ScummVM that text never appears.

 courseScript:changeState(1) displays the text with kDisplay and then
 immediately changes rooms, so this all happens on the same game cycle and
 there's no opportunity for ScummVM to update the screen. The reason it
 briefly appears in DOS is that kDisplay immediately writes to the screen
 so you get a glimpse before the room transition blows everything away.
 This was never the right thing for a script to do, but it might have
 looked okay at the time on a very slow DOS machine.

 The behavior they were fixing from earlier versions was "COURSE ALREADY
 ACHIEVED" displaying for three seconds during which all the buttons looked
 enabled but you couldn't do anything. Nothing worked during those three
 seconds and then things worked again with no visual cues.

 It looks to me like there's room to patch this script to introduce a
 formal delay so that the text appears for a short but reasonable moment
 before the room transition. I'll give that a shot later. There are a lot
 of versions of this game and this is a minor thing so if we can do a
 universal patch then great and if it's more complicated than that, well,
 at least we'll know what's going on. =)
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/13114#comment:1>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM