[Scummvm-tracker] [ScummVM :: Bugs] #13447: SCI: LSL3: Garbled music after autosave / GMM save

[ScummVM :: Bugs]

#13447: SCI: LSL3: Garbled music after autosave / GMM save
-------------------------+-----------------------------------
Reporter:  eriktorbjorn  |       Owner:  (none)
    Type:  defect        |      Status:  new
Priority:  normal        |   Component:  Engine: SCI
 Version:                |  Resolution:
Keywords:                |        Game:  Leisure Suit Larry 3
-------------------------+-----------------------------------
Comment (by athrxx):

 The bug report is a bit difficult to understand for me (is there one
 issue? or are there multiple issues?). What I can reproduce by saving in
 the scene where Kalalau waits at home is indeed an issue with the sound
 pausing/unpausing. Since it does not happen when entering and leaving the
 GMM (you really need to save) it is easy enough to track:

 It seems to be triggered by the call
 {{{

 g_sci->_soundCmd->pauseAll(false); // unpause music (we can't have it
 paused during save)

 }}}

 in metaengine.cpp, line 443. This unbalances our pause counters.

 The purpose of that line is not clear to me. When I comment it out, the
 issue seems to be fixed. I can load the saved game and the pause state is
 restored correctly. But that might be a premature assessment of mine. The
 line was added recently in this commit:
 https://github.com/scummvm/scummvm/commit/d8336a31ffbf12cfc4eb8687e5bb83e2dffa4964
 Apparently, it was found to be necessary. But I don't know why(yet).
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/13447#comment:2>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM