[Scummvm-tracker] [ScummVM :: Bugs] #9593: SCI: LSL5 (and others): port drawing issues
ScummVM :: Bugs
trac at scummvm.org
Fri Apr 29 04:17:16 UTC 2022
#9593: SCI: LSL5 (and others): port drawing issues
----------------------+-----------------------------------
Reporter: m-kiewitz | Owner: (none)
Type: defect | Status: new
Priority: normal | Component: Engine: SCI
Version: | Resolution:
Keywords: | Game: Leisure Suit Larry 5
----------------------+-----------------------------------
Comment (by sluicebox):
Hi Martin, it's been a while, great to hear from you! =)
I messed up and failed to comment here last year, but this ticket caused
me to compare QFG1 EGA screenshots and fix some off-by-one horizontal port
discrepancies, especially in the character screen:
https://github.com/scummvm/scummvm/commit/71235358e3f7c205e514168b5756ea1944ef3323
There are definitely still some mild discrepancies in ScummVM. The QFG1
EGA character creation screen still draws a one pixel vertical line on the
right edge that isn't in the original. But i also suspect that may be a
bug in the original, because that line is on the left and the symmetry
looks nice. Someone also recently showed me a message box in QFG1 EGA
PC-98 (or maybe it was SQ3?) that's drawn one pixel higher in ScummVM than
the original. My shallow investigation showed that not only is this likely
due to the differences between Sierra's and ScummVM's Rect classes, which
we all know of, but also that Sierra's own code had its own off-by-one
bugs that would be difficult and confusing to replicate, though not
impossible.
I propose that we limit the scope of this ticket, or close it, since many
things have been fixed since it was created, and open specific tickets as
they come up for remaining individual issues and include screenshots. I'm
not suggesting we dismiss port issues as "good enough", but at the same
time I also think they *are* pretty good and we should investigate
remaining individual discrepancies to see if there's anything we can
reasonably do.
--
Ticket URL: <https://bugs.scummvm.org/ticket/9593#comment:4>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM
More information about the Scummvm-tracker
mailing list