[Scummvm-tracker] [ScummVM :: Bugs] #13795: SCI: Sound volume not synced in fan games (was: Sound settings doesn't work for SCI games.)

[ScummVM :: Bugs]

#13795: SCI: Sound volume not synced in fan games
-------------------------+--------------------------
Reporter:  CortexReaver  |       Owner:  sluicebox
    Type:  defect        |      Status:  closed
Priority:  normal        |   Component:  Engine: SCI
 Version:                |  Resolution:  fixed
Keywords:  sound         |        Game:  SCI Fanmade
-------------------------+--------------------------
Changes (by sluicebox):

 * owner:  (none) => sluicebox
 * status:  new => closed
 * resolution:   => fixed
 * summary:  Sound settings doesn't work for SCI games. => SCI: Sound volume
     not synced in fan games

Comment:

 Fixed in:
 https://github.com/scummvm/scummvm/commit/0fd8ec67d5899143fc993c2f452bd3b4804c5ff0

 This game resets the volume to max as soon as it starts; that's why it
 didn't matter what you set the ScummVM volume to. Other fan games do too,
 since this code is from the SCI Studio template that it's based on. I've
 patched that out for compatibility, like we do with SCI32 games that do a
 similar thing.

 Also, like many fan games, the game's own volume controls are broken. It's
 a Sierra script bug that ended up in the template so it's in lots of
 games. This game has a different variant of that, so that's now fixed too.

 Thanks for reporting!
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/13795#comment:2>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM