[Scummvm-tracker] [ScummVM :: Bugs] #13809: 11th hour localized file issue & fix
ScummVM :: Bugs
trac at scummvm.org
Tue Aug 30 14:23:07 UTC 2022
#13809: 11th hour localized file issue & fix
----------------------+-----------------------------
Reporter: lolovo | Owner: (none)
Type: defect | Status: new
Priority: normal | Component: Engine: Groovie
Version: | Keywords: groovie2
Game: 11th Hour |
----------------------+-----------------------------
Hi,
I've faced with an issue described here -
[https://forums.scummvm.org/viewtopic.php?t=16661]. As it was mentioned it
is a specific of localized files. I've noticed that in roq.cpp:547 for
seek of end position endpos is used and this leeds to crash, but maybe
appropriate try will be using file->pos in this case (I'm not the
spicialist in scummvm code, as well as groovie engine). Anyway when
file->pos is used the issue is solved (no crash anymore). The fix is the
following:
{{{
...
if (endpos != _file->pos()) {
warning("Groovie::ROQ: BLOCK %04x Should have ended at %d,
and has ended at %d", blockHeader.type, endpos, (int)_file->pos());
warning("Ensure you've copied the files correctly
according to the wiki.");
_file->seek(_file->pos());//was _file->seek(endpos);
}
...
}}}
Could you please verify this and maybe integrate this in project. With
this fix my issue is solved. Thanks!
--
Ticket URL: <https://bugs.scummvm.org/ticket/13809>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM
More information about the Scummvm-tracker
mailing list