[Scummvm-tracker] [ScummVM :: Bugs] #13193: BURIED: Arthur still visible after being lost from Biochip Inventory

[ScummVM :: Bugs]

#13193: BURIED: Arthur still visible after being lost from Biochip Inventory
-------------------------+-------------------------------------------------
Reporter:  jamie-        |       Owner:  bluegr
  marchant               |
    Type:  defect        |      Status:  closed
Priority:  normal        |   Component:  Engine: Buried
 Version:                |  Resolution:  fixed
Keywords:                |        Game:  Journeyman Project 2: Buried in
                         |  Time
-------------------------+-------------------------------------------------
Changes (by bluegr):

 * status:  new => closed
 * resolution:   => fixed

Comment:

 When Arthur sacrifices himself in Agent 3's lair, the steps performed are
 the following:
 - Arthur's biochip is removed from the inventory
 - The blank chip is added to the inventory
 - The current inventory item is set to the currently added one (this is
 what happens when a new item is added)
 - If Arthur's biochip was previously shown on the right, the blank chip
 will be shown on the right instead  (that's what has been done in this
 fix)

 Both of these issues are present in the original. In this specific scene,
 there is an action which occurs asynchronously (Arthur's chip being
 destroyed and replaced with a blank chip). While this happens, the player
 is free to perform any sort of action, and when Arthur finishes his
 speech, the scripted event occurs.

 We fixed the biochip shown on the right, but it's not easy to fix the
 selection of the inventory item without adding workarounds for specific
 cases that I wouldn't want to add. The inventory is updated with the blank
 biochip, and if the player has the files screen open, he is supposed to
 see that. Opening the files screen while listening to Arthur dying is
 surely an edge case, and I don't see any benefit to add workarounds for
 changing the currently selected item in this scene with specific item
 combinations, because we might introduce other unwanted bugs and side
 effects, for no real gain.

 Thus, I'm closing this bug again - we haven't introduced a regression with
 our changes, and we don't need to mess up with core game logic and
 introduce other potential bugs for no real gain.
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/13193#comment:14>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM