[Scummvm-tracker] [ScummVM :: Bugs] #13195: SHERLOCK: UI glitch when looking at screen object in inventory mode (Demo)

[ScummVM :: Bugs]

#13195: SHERLOCK: UI glitch when looking at screen object in inventory mode (Demo)
-------------------------------------+-------------------------------------
Reporter:  antoniou79                |       Owner:  (none)
    Type:  defect                    |      Status:  new
Priority:  normal                    |   Component:  Engine: Sherlock
 Version:                            |  Resolution:
Keywords:  Case of the Serrated      |        Game:  Sherlock Holmes: Case
  Scalpel, DOS, Demo, UI, glitch     |  of the Serrated Scalpel
-------------------------------------+-------------------------------------
Comment (by eriktorbjorn):

 The problem seems to be in ScalpelUserInterface::examine(). It checks if
 the inventory is open before printing the object description, ''except''
 if the description is printed as part of an animation. Moving the check to
 earlier in the function ''seems'' to fix the problem, i.e.:

 {{{
 diff --git a/engines/sherlock/scalpel/scalpel_user_interface.cpp
 b/engines/sherl
 ock/scalpel/scalpel_user_interface.cpp
 index 7c780f4650d..9e590b7808e 100644
 --- a/engines/sherlock/scalpel/scalpel_user_interface.cpp
 +++ b/engines/sherlock/scalpel/scalpel_user_interface.cpp
 @@ -533,6 +533,13 @@ void ScalpelUserInterface::examine() {
         Talk &talk = *_vm->_talk;
         Common::Point pt = events.mousePos();

 +       if (_invLookFlag) {
 +               // Don't close the inventory window when starting an
 examine dis
 play, since its
 +               // window will slide up to replace the inventory display
 +               _windowOpen = false;
 +               _menuMode = LOOK_MODE;
 +       }
 +
         if (pt.y < (CONTROLS_Y + 9)) {
                 Object &obj = scene._bgShapes[_bgFound];

 @@ -560,13 +567,6 @@ void ScalpelUserInterface::examine() {
                         _vm->setFlags(inv[_selector]._lookFlag);
         }

 -       if (_invLookFlag) {
 -               // Don't close the inventory window when starting an
 examine display, since its
 -               // window will slide up to replace the inventory display
 -               _windowOpen = false;
 -               _menuMode = LOOK_MODE;
 -       }
 -
         if (!talk._talkToAbort) {
                 if (!scene._cAnimFramePause)
                         printObjectDesc(_cAnimStr, true);
 }}}
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/13195#comment:2>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM