[Scummvm-tracker] [ScummVM :: Bugs] #13216: WEB: "Other" screenshots page is broken

[ScummVM :: Bugs]

#13216: WEB: "Other" screenshots page is broken
-------------------------+-------------------------
Reporter:  Thunderforge  |      Owner:  (none)
    Type:  defect        |     Status:  new
Priority:  normal        |  Component:  Web
 Version:                |   Keywords:  screenshots
    Game:                |
-------------------------+-------------------------
 On any screenshots page for a game or series (say
 [http://scummvm.org/screenshots/lucasarts/loom/ Loom]), at the bottom of
 the page is a "Back" button that goes up one level to the company category
 (in Loom's case, [https://www.scummvm.org/screenshots/lucasarts/
 LucasArts]).

 Games that are in the "Other Games" category (such as
 [https://www.scummvm.org/screenshots/other/teenagent/ Teen Agent]) has a
 back button that goes to https://www.scummvm.org/screenshots/other, but
 this page results in the following error:

 > There was a problem processing your request:
 >
 > Invalid category specified.

 == Initial findings

 The "Invalid category specified" error is thrown on
 [https://github.com/scummvm/scummvm-
 web/blob/1a2535861e902043e2afe506c0ca3ad0eeff34d6/include/Models/ScreenshotsModel.php#L51
 this line]. The issue is that the page is looking for screenshots matching
 a company name of "Other", finds none, and throws an error.

 The "Other" category is generated by [https://github.com/scummvm/scummvm-
 web/blob/1a2535861e902043e2afe506c0ca3ad0eeff34d6/include/OrmObjects/ScreenshotQuery.php#L55
 this query] for any company where no more than one game exists.

 I also discovered that you can go to a game's screenshot page if the
 "other" in the URL is the company id. In other words, these two are
 interchangeable:

 * https://www.scummvm.org/screenshots/other/teenagent/
 * https://www.scummvm.org/screenshots/metropolis/teenagent/

 == Possible Solutions

 It seems that there are two solutions we could pursue:

 * Fix the query so that searching for "Other" results in a properly
 generated page showing screenshots for all companies that have a single
 game
 * Change the screenshot page so that the hyperlinks go to the company-
 specific pages (e.g. `screenshots/metropolis/teenagent/`) so that the Back
 button goes to the company page (`screenshots/other/`). Then the
 screenshots page has an "Other" category grouping that is purely cosmetic
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/13216>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM