[Scummvm-tracker] [ScummVM :: Bugs] #13603: BASE: Detection: plumbers.plugin produce crash on adding games and start of games (was: LAUNCHER: Crash in detection plugin (Add game and start certain games))

[ScummVM :: Bugs]

#13603: BASE: Detection: plumbers.plugin produce crash on adding games and start of
games
------------------------------------------------+--------------------------
Reporter:  raziel-                              |       Owner:  (none)
    Type:  defect                               |      Status:  new
Priority:  normal                               |   Component:  Engine:
                                                |  Plumbers
 Version:                                       |  Resolution:
Keywords:  Big Endian, PPC, plugins, add games  |        Game:
------------------------------------------------+--------------------------
Changes (by raziel-):

 * keywords:  Big Endian, PPC, plugins => Big Endian, PPC, plugins, add
               games
 * component:  Common => Engine: Plumbers
 * summary:  LAUNCHER: Crash in detection plugin (Add game and start certain
     games) =>
     BASE: Detection: plumbers.plugin produce crash on adding games and
     start of games

Comment:

 @dwatteau

 > This is on AmigaOS 4, and with 2.7.0git, right?
 Yes, but also on 2.6 and some revisions beforehand, i can't do a bisect
 easily, since i have to manually download a revision, build and check, so
 i haven't checked many

 > Did you also have the problem with the 2.6.0pre-release version?
 Yes, see above

 > Was it a debug build or a release build? (i.e. was the -g GCC flag
 used?).
 Both, but i explicitely test with debug builds to get the most out of the
 crash logs

 > Did it use to work at some point, or has this issue always been there
 with plugins?
 Nope, it used to work for a long time, but i can't pinpoint when it
 started to act up, probably somewhere around when the metaengines stuff
 was revised (but that is a long shot in the dark)

 > Was it a Mass Add or just the standard Add Game action?
 Both, and it crashes on starting games aswell (absolutely unusable in the
 current form)

 @lephilousophe

 > Did you try with buildbot builds?
 Still not tried, will report back when i did (soon-ish)

 > Since when does it fail and does it fail with future release too?
 Yes, and please see mny answer to @dwatteau above

 > I am not sure the problem is size related it seems that the detection
 plugin has a problem at execution (and not at load).
 You are right, it's only one engine, plumbers, that causes it.
 (And of course it's the smallest engine...i was bisecting manually by
 taking out two engines starting from the biggeest and going down,
 compiling, testing...two days wasted, if i only had started with the
 smallest...sigh)

 If i take the plumbers engine out, everything is back to normal.
 I have yet to test all engines except plumbers, but i'm pretty sure that
 is the culprit.

 > Could you please try the following commands instead:
 - scummvm --list-all-games
 - scummvm --list-all-engines

 I'm getting all the engines that are actually built in, even plumbers show
 up

 > You can also set the debuglevel to 9 (edit the settings file) to make
 sure nothing fishy happens during the enumeration.
 If you still need the debug output i'll add it later

 ...


 Hopefully someone can make out something in the stacktrace now?
 nb: EVERY stacktrace looks EXACTLY the same, no matter what engines are
 built in, as long as plumbers is there to crash...
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/13603#comment:2>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM