[Scummvm-tracker] [ScummVM :: Bugs] #13372: "Trim FM-Towns games to 200 pixels height" option doesn't appear in Loom FM-Towns (was: "Trim FM-Towns games to 200 pixels height" option doesn't appear in all FM-Towns games)

[ScummVM :: Bugs]

#13372: "Trim FM-Towns games to 200 pixels height" option doesn't appear in Loom
FM-Towns
-----------------------------------------------+---------------------------
Reporter:  LukasThyWalls                       |       Owner:  (none)
    Type:  defect                              |      Status:  new
Priority:  normal                              |   Component:  Engine:
                                               |  SCUMM
 Version:                                      |  Resolution:
Keywords:  FM-Towns, Option, Trim 200 pixels,  |        Game:  Loom
-----------------------------------------------+---------------------------
Changes (by LukasThyWalls):

 * keywords:  FM-Towns, Option, => FM-Towns, Option, Trim 200 pixels,
 * game:   => Loom
 * summary:
     "Trim FM-Towns games to 200 pixels height" option doesn't appear in
     all FM-Towns games
     =>
     "Trim FM-Towns games to 200 pixels height" option doesn't appear in
     Loom FM-Towns


Old description:

> The option "Trim FM-Towns games to 200 pixels height" in Game tab for FM-
> Towns games doesn't appear in all of them.
>
> I have installed Zak FM-Towns (Directly from GOG version) with and
> without a Spanish fan patch, and the only version with that option is the
> one with the Spanish fan translation, not the one with the vanilla files
> from the GOG version.
> Also i tested a Loom FM-Towns with a Spanish fan translation, and also
> doesn't show the option.
>
> The setting works for the one it shows it.
>
> In ScummVM.ini file, the only one game entry with the setting
> "trim_fmtowns_to_200_pixels" is the one that is showing it in the GUI.

New description:

 The option "Trim FM-Towns games to 200 pixels height" in Game tab for FM-
 Towns games doesn't appear in ~~all of them~~ Loom FM-Towns.

 ~~I have installed Zak FM-Towns (Directly from GOG version) with and
 without a Spanish fan patch, and the only version with that option is the
 one with the Spanish fan translation, not the one with the vanilla files
 from the GOG version.~~
 Also i tested a Loom FM-Towns with a Spanish fan translation, and also
 doesn't show the option.

 The setting works for the one it shows it.

 In ScummVM.ini file, the only games entry with the setting
 "trim_fmtowns_to_200_pixels" is the one that is showing it in the GUI.

--
Comment:

 eriktorbjorn is correct.

 Using 2.6.0git4526-g1d1a12b3aca, i remove and added again zak-fm in both
 english and spanish (fan translation) and now in both appears the setting.
 Is strange because when i added them before (it's been a while) it was in
 a consecutive way: copying the files from GOG, copying the folder twice,
 applying the spanish patch to one, and adding both to ScummVM at the same
 time. Maybe i'm remembering wrong, but anyway, the settings appears now in
 both.

 But it's true, the Loom FM-Towns doesn't add the option. As seen in
 https://github.com/scummvm/scummvm/blob/master/engines/scumm/detection_tables.h#L181,
 the detection lacks the GUIO_TRIM_FMTOWNS_TO_200_PIXELS flag.

 If it's intended that flag can be used in Loom FM-Towns for any reason
 yet, this bug can be closed. I edited the bug to reflect the issue now
 it's about Loom FM-Towns only.

 Thanks.
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/13372#comment:2>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM