[Scummvm-tracker] [ScummVM :: Bugs] #13459: Escape from Monkey Island memory crash during movies playing

[ScummVM :: Bugs]

#13459: Escape from Monkey Island memory crash during movies playing
---------------------+----------------------------------------
Reporter:  getaaron  |       Owner:  (none)
    Type:  defect    |      Status:  new
Priority:  normal    |   Component:  Engine: Grim
 Version:            |  Resolution:
Keywords:            |        Game:  Escape from Monkey Island
---------------------+----------------------------------------
Comment (by getaaron):

 After some more testing, the one on Lucre Island is 100% reproducible
 (it's blocking continuing in the game)

 Looks like it's always crashing in the {{{SDLTimer}}} thread (not the main
 thread as I thought above

 Here's a recent example

 {{{
 Thread 11 Crashed:: SDLTimer
 0   libGL.dylib                                0x20584de84 glDeleteBuffers
 + 16
 1   scummvm                                    0x104db1860 0x104120000 +
 13178976
 2   scummvm                                    0x104df18c4 0x104120000 +
 13441220
 3   scummvm                                    0x104df1a38 0x104120000 +
 13441592
 4   scummvm                                    0x104dc5b34 0x104120000 +
 13261620
 5   scummvm                                    0x104d8f680 0x104120000 +
 13039232
 6   scummvm                                    0x104d90770 0x104120000 +
 13043568
 7   scummvm                                    0x104d904bc 0x104120000 +
 13042876
 8   scummvm                                    0x1066b5d14 0x104120000 +
 39410964
 9   scummvm                                    0x1067243a8 0x104120000 +
 39863208
 10  scummvm                                    0x106be1ca0 0x104120000 +
 44833952
 11  scummvm                                    0x106be1840 0x104120000 +
 44832832
 12  scummvm                                    0x106c3258c 0x104120000 +
 45163916
 13  libsystem_pthread.dylib                    0x1a41e5240 _pthread_start
 + 148
 14  libsystem_pthread.dylib                    0x1a41e0024 thread_start +
 8
 }}}

 So I'm guessing the line that triggers the crash is
 https://github.com/scummvm/scummvm/blob/8b4e75ded7a4d02adc5efcbc5aa5fd54e12f24fe/engines/grim/gfx_opengl_shaders.cpp#L1521
 but I don't know much about OpenGL or why we would be deleting shaders
 while a movie is playing
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/13459#comment:5>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM