[Scummvm-tracker] [ScummVM :: Bugs] #13460: SCUMM: DOTT: Incorrect MIDI pitch bending

[ScummVM :: Bugs]

#13460: SCUMM: DOTT: Incorrect MIDI pitch bending
----------------------+----------------------------------
Reporter:  AndywinXp  |       Owner:  (none)
    Type:  defect     |      Status:  new
Priority:  normal     |   Component:  Engine: SCUMM
 Version:             |  Resolution:
Keywords:  adlib      |        Game:  Day of the Tentacle
----------------------+----------------------------------
Comment (by athrxx):

 Unfortunately, in our imuse implementation too many things have been
 factored out of the ims drivers into the common code.

 The original drivers do have their individual clipping ranges and their
 individual handlings of transpose, detune and pitch bend commands.

 What we do in imuse_part.cpp, line 374, might actually be right for the
 MT-32 driver. I don't know if that driver has that sort of code (could be,
 since it appparently works as intended) or if it is an invention of the
 author of our code.

 When running the DOTT intro with AdLib setting, at the point where the
 bird is dropping down,  it will repeatedly call Player::setTranspose() and
 that clipping from imuse_part.cpp, line 374 kicks in. That clipping is
 probably the cause of the sound glitch.

 When I made the Amiga driver I fixed the transpose issue for that driver
 (see imuse_part.cpp, lines 148-153, 373, 377-388), but it seems it would
 be worthwhile to check the other drivers, too. Maybe it would suffice to
 adapt the clipping range...
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/13460#comment:1>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM