[Scummvm-tracker] [ScummVM :: Bugs] #13460: SCUMM: DOTT: Incorrect MIDI pitch bending

ScummVM :: Bugs trac at scummvm.org
Sat May 7 11:38:47 UTC 2022


#13460: SCUMM: DOTT: Incorrect MIDI pitch bending
----------------------+----------------------------------
Reporter:  AndywinXp  |       Owner:  (none)
    Type:  defect     |      Status:  new
Priority:  normal     |   Component:  Engine: SCUMM
 Version:             |  Resolution:
Keywords:  adlib      |        Game:  Day of the Tentacle
----------------------+----------------------------------
Comment (by AndywinXp):

 Here's what's different for v5 (FOA/MI2):

 {{{
 IMUSE_UTILS_ClampTuning(tuning, min, max) {
   int16 clampedTuning;

   clampedTuning = tuning;
   if ( tuning < min ) {
     clampedTuning = 12 * ((uint16)(min - tuning - 1) / 12) + 12 + tuning;
     tuning = clampedTuning;
   }

   if ( clampedTuning > max )
     clampedTuning += -12 - 12 * ((uint16)(tuning - max - 1) / 12);

   return clampedTuning;
 }
 }}}

 {{{
 IMUSE_PART_SetTranspose(partPtr, partId, relative, transpose) {
   if ( transpose <= 24 && transpose >= -24 ) {
     if ( partId == 16 ) {
       for ( curPart = partPtr->next; curPart; curPart = curPart->next ) {
         if (curPart->effTranspose != 128) {
           curPart->effTranspose = IMUSE_UTILS_ClampTuning(transpose +
 curPart->transpose, -12, 12);
           IMUSE_PART_SendTransposeToMIDIDevice(curPart);
         }
       }
     } else { /* Don't care */ }
   }
 }
 }}}
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/13460#comment:6>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM


More information about the Scummvm-tracker mailing list