[Scummvm-tracker] [ScummVM :: Bugs] #13460: SCUMM: DOTT: Incorrect MIDI pitch bending

[ScummVM :: Bugs]

#13460: SCUMM: DOTT: Incorrect MIDI pitch bending
----------------------+----------------------------------
Reporter:  AndywinXp  |       Owner:  (none)
    Type:  defect     |      Status:  new
Priority:  normal     |   Component:  Engine: SCUMM
 Version:             |  Resolution:
Keywords:  adlib      |        Game:  Day of the Tentacle
----------------------+----------------------------------
Comment (by athrxx):

 Looks fishy. But what's the point of even asking, that commit is from a
 guy who left the scene 20 years ago...

 Just checking why this never came up for MI2/Amiga, since I did have
 issues with that, there. Turns out that Player::setTranspose() is never
 used there...

 At first glace I would assume that the
 {{{
 part->set_transpose(part->_transpose)
 }}}

 is a typo and it should just be

 {{{

 part->set_transpose(_transpose)

 }}}

 However, the actual operation seems to take place in Part::set_transpose.
 The player transpose value is queried and added there. So it might be
 intended. Don't ask me why. But otherwise the player transpose would
 probably be added twice...
-- 
Ticket URL: <https://bugs.scummvm.org/ticket/13460#comment:9>
ScummVM :: Bugs <https://bugs.scummvm.org>
ScummVM